Remove duplicated condition in primary key check #1240
Conversation
Motivation: We had a redundant check (`col.primary_key or col.primary_key`) that caused confusion and had no logical effect. Modifications: Removed the duplicated check, leaving only a single condition for `col.primary_key`. Result: The code is now clearer and avoids unnecessary duplication.
|
+1 LGTM |
|
Thanks for the PR @daniloarodrigues! That is indeed a pretty awesome find... 🤦 Have you signed the Contributor License Agreement for contributions to DataStax open source projects? If not you can find it at https://cla.datastax.com/. Thanks! |
I've just signed up. Thanks for letting me know. |
|
Just kicked off a full CI run on this guy just to make absolutely sure there's no regression. I can't imagine how there could be but... I've been surprised before. I've also looked at the referenced code like ten times to make sure those things in fact say the same thing. Assuming there's nothing unexpected with the build (and I'm not expecting anything) this will go straight in. |
|
As expected PR build was clean, so we should be good to get this merged. Thanks for the contribution @daniloarodrigues! |
Motivation:
We had a redundant check (
col.primary_key or col.primary_key) that caused confusion and had no logical effect.Modifications:
Removed the duplicated check, leaving only a single condition for
col.primary_key.Result:
The code is now clearer and avoids unnecessary duplication.